fix: fix polygonize dropping body area for polygons with touching holes#2
Merged
bvacherot-sofar merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
a1241f8 to
8ebd9f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant test:
polygonize_preserves_enclosed_taiwan_polygon_minimal_matches_fixturea small repro case. The initial polygons cover Taiwan, and the output polygons do not.src/graph/topology_cleanup.rsthe proposed fixRoot cause in
split_touching_boundary_polygon: thesplit_faces.len() >= 2branch assumes the extracted minimal edge rings fully tile the original polygon body. That assumption only holds when the body is simply connected (one connected component). For a polygon with holes whose body is multiply-connected (exterior — holes forms one piece), the body cannot be represented as a single minimal edge ring and the extracted sub-faces only cover "pockets" between touching holes; the bulk of the body is silently discarded.Fix (
src/graph/topology_cleanup.rs): gate the>= 2split branch on the original polygon'sinterior_point()being covered by at least one split face. When the coverage check fails on a holed polygon, fall back toselect_non_touching_holes, which preserves the exterior.